fix: update nodeModulesDir config JSON schema

[marvinhagemeister]

Ref #25380

[dsherret]

I think maybe we should flip this to true after the deno 2.0 release? This will go live immediately after merging.

[marvinhagemeister]

Oh good point

[bartlomieju]

This setting hasn't landed in v1.46 IIRC so why are we changing it in config-file.v1.json? Shouldn't we add a new version of the schema file?

[dsherret]

This setting hasn't landed in v1.46 IIRC so why are we changing it in config-file.v1.json? Shouldn't we add a new version of the schema file?

I think that's going to be too much work to do before Deno 2.0 because this is managed by the vscode extension independent of the CLI. I think we should look into that post Deno 2.0.

[bartlomieju]

But now people who use v1.4X will have squiggly lines for nodeModulesDir and deprecated "files" config. It shouldn't be too much work to select the proper schema file based on the version. @nayeemrmn can you chime in here?

[dsherret]

But now people who use v1.4X will have squiggly lines for nodeModulesDir and deprecated "files" config.

@bartlomieju No. See #25653 (comment) -- it was flipped

[dsherret]

Oh, files config was already removed, but we've been warning about that one for ages so it's probably fine.

[petamoriken]

Will TypeScript 5.6 be supported in Deno v1.x? If not, it may be better to separate schema files because of new compilerOptions such as "strictBuiltinIteratorReturn".