Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/fetch): fix lowercase http_proxy classified as https #25686

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix(ext/fetch): fix lowercase http_proxy classified as https #25686

merged 2 commits into from
Sep 19, 2024

Conversation

seanmonstar
Copy link
Contributor

While investigating something else, I noticed this typo which treated http_proxy as Filter::Https.

dsherret
dsherret approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret enabled auto-merge (squash) September 17, 2024 17:39
@dsherret dsherret merged commit 6806535 into denoland:main Sep 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanmonstar @dsherret @satyarohith