Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/node): add rootCertificates to node:tls #25707

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Sep 18, 2024

Closes #25604

Alternative to #25701


Co-authored-by: Satya Rohith me@satyarohith.com

Co-authored-by: Satya Rohith <me@satyarohith.com>
ext/node/ops/tls.rs Outdated Show resolved Hide resolved
Signed-off-by: Satya Rohith <me@satyarohith.com>
ext/node/ops/tls.rs Outdated Show resolved Hide resolved
Signed-off-by: Satya Rohith <me@satyarohith.com>
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice 👍

@bartlomieju bartlomieju merged commit ab1e391 into main Sep 18, 2024
17 checks passed
@bartlomieju bartlomieju deleted the node_root_certs_using_proxy branch September 18, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node:tls rootCertificates is undefined
5 participants