fix: don't prompt when using Deno.permissions.request with --no-prompt
#25811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowlighter
force-pushed
the
fix-14668
branch
from
eec78a8
to
3884b9e
Compare
lowlighter
force-pushed
the
fix-14668
branch
from
3884b9e
to
5cfd12e
Compare
lowlighter
changed the title
Deno.permissions.request when --no-prompt is setDeno.permissions.request with --no-prompt
|
Thanks for the PR, unfortunately I think this test is not correct - if you are in non-TTY environment (eg. in a CI) the prompting won't happen anyway. I believe we'll need to have this test use PTY - eg. check |
|
I've updated the test to use a PTY environment like suggested |
lowlighter
commented
Sep 23, 2024
| @@ -3438,7 +3441,8 @@ mod tests { | |||
| fn test_request() { | |||
| set_prompter(Box::new(TestPrompter)); | |||
| let parser = TestPermissionDescriptorParser; | |||
| let mut perms: Permissions = Permissions::none_without_prompt(); | |||
There was a problem hiding this comment.
I've changed this to none_with_prompt() because it seemed like a mistake, since later in the test we manipulate the prompt value. I feel like this is why it has been overlooked in the first place, though I could be wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14668