Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update deno_npm to fix deno install with crossws #25837

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix: Update deno_npm to fix deno install with crossws #25837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
722913a
Update deno_npm to 0.25.2
nathanwhit Sep 23, 2024
04bf1a5
Add test
nathanwhit Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ deno_doc = { version = "0.148.0", features = ["html", "syntect"] }
deno_graph = { version = "=0.82.1" }
deno_lint = { version = "=0.67.0", features = ["docs"] }
deno_lockfile.workspace = true
deno_npm = "=0.25.1"
deno_npm = "=0.25.2"
deno_package_json.workspace = true
deno_runtime = { workspace = true, features = ["include_js_files_for_snapshotting"] }
deno_semver.workspace = true
Expand Down
Empty file added tests/registry/npm/@denotest/non-existent-optional-peer/1.0.0/index.js
View file
Open in desktop
Empty file.
12 changes: 12 additions & 0 deletions tests/registry/npm/@denotest/non-existent-optional-peer/1.0.0/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"name": "@denotest/non-existent-optional-peer",
"version": "1.0.0",
"peerDependencies": {
"uWebSockets.js": "*"
},
"peerDependenciesMeta": {
"uWebSockets.js": {
"optional": true
}
}
}
11 changes: 11 additions & 0 deletions tests/specs/install/non_existent_optional_peer/__test__.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// test imitates what crossws 0.2.4 has https://www.npmjs.com/package/crossws/v/0.2.4
// where uWebSockets.js is an optional peer dep, but doesn't exist on npm
{
"tempDir": true,
"steps": [
{
"args": "install",
"output": "install.out"
}
]
}
6 changes: 6 additions & 0 deletions tests/specs/install/non_existent_optional_peer/install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[UNORDERED_START]
Download http://localhost:4260/@denotest/non-existent-optional-peer
Download http://localhost:4260/uWebSockets.js
Download http://localhost:4260/@denotest/non-existent-optional-peer/1.0.0.tgz
[UNORDERED_END]
Initialize @denotest/non-existent-optional-peer@1.0.0
5 changes: 5 additions & 0 deletions tests/specs/install/non_existent_optional_peer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"dependencies": {
"@denotest/non-existent-optional-peer": "1.0.0"
}
}