fix: Panic in Deno Install on Windows Related to Semver Handling #25863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iately, preventing panics related to the usage of `matches` with a tag. fix denoland#25861
|
@nathanwhit @dsherret |
…dows' into Fix-Panic-in-Deno-Install-on-Windows
|
This code is a bit tricky and hard to get right, so since I'm very familiar with this code I'd prefer to fix this one myself – but thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the version matching logic to handle pre-release tags appropriately, preventing panics related to the usage of
matcheswith a tag.fix #25861