Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: include sha256 checksum in release #25869

Merged
merged 4 commits into from
Sep 30, 2024
Merged

chore: include sha256 checksum in release #25869

merged 4 commits into from
Sep 30, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Sep 25, 2024 •
edited by bartlomieju
Loading

Closes #7253

@littledivy littledivy mentioned this pull request Sep 25, 2024
Draft
bartlomieju
bartlomieju approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these are not uploaded in any way. Can you update calls to gsutil to also copy checksum files?

Also the tools/release/release_doc_template.md should be updated with correct no of files that are expected on GH release and dl.deno.land.

@littledivy
Copy link
Member Author

It is part of the ZIP that's uploaded to gcs and gh releases. Asset count stay the same

@bartlomieju
Copy link
Member

It is part of the ZIP that's uploaded to gcs and gh releases. Asset count stay the same

Okay, thanks for clarification. I think we should still expose checksum files so they can be downloaded independent of the zip file. WDYT?

@littledivy littledivy merged commit 05ca699 into denoland:main Sep 30, 2024
17 checks passed
@littledivy littledivy deleted the deno_sha256sum branch September 30, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: generate checksum for release file
2 participants
@littledivy @bartlomieju