Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install): warn repeatedly about not-run lifecycle scripts on explicit installs #25878

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

nathanwhit
Copy link
Member

Currently we only warn once. With this PR, we continue to warn about not-run scripts on explicit deno install (or cache). For run (or other subcommands) we only warn the once, as we do currently.

@nathanwhit nathanwhit changed the title chore: Warn repeatedly about not-run lifecycle scripts on explicit installs chore: warn repeatedly about not-run lifecycle scripts on explicit installs Sep 26, 2024
@dsherret dsherret changed the title chore: warn repeatedly about not-run lifecycle scripts on explicit installs feat(install): warn repeatedly about not-run lifecycle scripts on explicit installs Sep 26, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cli/args/flags.rs Outdated Show resolved Hide resolved
@nathanwhit nathanwhit enabled auto-merge (squash) September 26, 2024 16:38
@nathanwhit nathanwhit merged commit 543c687 into denoland:main Sep 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants