Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): correctly handle old jsx in linter #25902

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix(lint): correctly handle old jsx in linter #25902

merged 2 commits into from
Sep 27, 2024

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Sep 27, 2024 •
edited
Loading

Previously the CLI was incorrectly reporting React as unused in a JSX file that uses the "old" transform.

The LSP was already handling this correctly.

marvinhagemeister
marvinhagemeister approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@lucacasonato lucacasonato enabled auto-merge (squash) September 27, 2024 13:59
@lucacasonato lucacasonato merged commit 6f0fbce into denoland:main Sep 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @marvinhagemeister