fix(install): surface package.json dependency errors #26023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Oct 3, 2024
nathanwhit
reviewed
Oct 3, 2024
cli/tools/registry/pm.rs
Outdated
| } | ||
|
|
||
| Ok(()) | ||
| } | ||
|
|
||
| async fn npm_install_after_modification( | ||
| flags: Arc<Flags>, | ||
| // todo(dsherret): why is this dependency being passed here? |
There was a problem hiding this comment.
Oops, that was me.
The reason is because we create our own JsrFetchResolver in add from deps_file_fetcher, and we to reuse that file fetcher in cache_top_level_deps.
If we create a new JsrFetchResolver in cache_top_level_deps instead of passing our existing one, it redownloads meta.json files (and logs again), since it has a new file fetcher.
It's very possible there's a cleaner way to fix that, though
There was a problem hiding this comment.
Ah I see. Thanks! I'll update this comment tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.