Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish): add --set-version <version> flag #26141

Merged
merged 13 commits into from
Nov 20, 2024

Conversation

ckrassow
Copy link
Contributor

@ckrassow ckrassow commented Oct 11, 2024

This PR adds a --set-version flag to the deno publish subcommand.

First contribution so likely something I missed. Added a test in test/specs/publish called "successful_override_version". I made a PR few days ago but realized I missed some steps so closed it and will use this one instead. Also not sure if this is considered a feat or fix but guessing feat fits better.

Issue: #22663

@ckrassow ckrassow marked this pull request as ready for review October 11, 2024 06:24
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ckrassow!

We need to decide how this feature should behave in a workspace.

Nit on flag name: I think --set-version flag is more preferable vs --override-version since --set-* prefix is more common and shorter.

@ckrassow
Copy link
Contributor Author

Thanks for the contribution @ckrassow!

We need to decide how this feature should behave in a workspace.

Nit on flag name: I think --set-version flag is more preferable vs --override-version since --set-* prefix is more common and shorter.

Okay, yeah I can see how the flag name makes more sense! I guess i'll just wait and see what you guys decide with how the feature should behave in the workspace as you say?

@dsherret dsherret added this to the 2.1.0 milestone Oct 15, 2024
cli/args/flags.rs Outdated Show resolved Hide resolved
cli/args/flags.rs Outdated Show resolved Hide resolved
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ckrassow!

LGTM. I'll let @dsherret merge the PR after review.

@dsherret dsherret changed the title feat(cli): Add override version publish flag feat(publish): add --override-version <version> flag Nov 19, 2024
@dsherret dsherret changed the title feat(publish): add --override-version <version> flag feat(publish): add --set-version <version> flag Nov 19, 2024
"name": "{}",
"version": "{}",
"exports": "{}"
}}"#,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is introducing a change in the message. Surprisingly we don't have a test for this to have caught this.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret enabled auto-merge (squash) November 19, 2024 23:30
@dsherret dsherret disabled auto-merge November 19, 2024 23:40
@dsherret dsherret enabled auto-merge (squash) November 19, 2024 23:41
@dsherret dsherret merged commit 9956731 into denoland:main Nov 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants