-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(publish): add --set-version <version>
flag
#26141
feat(publish): add --set-version <version>
flag
#26141
Conversation
…n tests/specs/publish
…ride-version-publish-flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @ckrassow!
We need to decide how this feature should behave in a workspace.
Nit on flag name: I think --set-version
flag is more preferable vs --override-version
since --set-*
prefix is more common and shorter.
Okay, yeah I can see how the flag name makes more sense! I guess i'll just wait and see what you guys decide with how the feature should behave in the workspace as you say? |
…-version flag in workspace
…ride-version-publish-flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--override-version <version>
flag
--override-version <version>
flag--set-version <version>
flag
cli/tools/registry/mod.rs
Outdated
"name": "{}", | ||
"version": "{}", | ||
"exports": "{}" | ||
}}"#, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is introducing a change in the message. Surprisingly we don't have a test for this to have caught this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This PR adds a --set-version flag to the deno publish subcommand.
First contribution so likely something I missed. Added a test in test/specs/publish called "successful_override_version". I made a PR few days ago but realized I missed some steps so closed it and will use this one instead. Also not sure if this is considered a feat or fix but guessing feat fits better.
Issue: #22663