Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support node-api in denort #26389

Merged
merged 1 commit into from
Oct 24, 2024
Merged

feat: support node-api in denort #26389

merged 1 commit into from
Oct 24, 2024

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Oct 18, 2024

exposes node-api symbols in denort so that deno compile can run native addons.

@devsnek devsnek added the ci-draft Run the CI on draft PRs. label Oct 18, 2024
@devsnek devsnek marked this pull request as ready for review October 23, 2024 17:46
@devsnek devsnek force-pushed the napi-deno-compile branch 3 times, most recently from 886e0d6 to e4adeb9 Compare October 23, 2024 18:21
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devsnek devsnek merged commit 79a3ad2 into main Oct 24, 2024
17 checks passed
@devsnek devsnek deleted the napi-deno-compile branch October 24, 2024 07:13
bartlomieju pushed a commit that referenced this pull request Oct 25, 2024
exposes node-api symbols in denort so that `deno compile` can run native
addons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-draft Run the CI on draft PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants