Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add --unstable-node-globals flag #26617

Merged
merged 4 commits into from
Nov 14, 2024
Merged

feat(cli): add --unstable-node-globals flag #26617

merged 4 commits into from
Nov 14, 2024

Conversation

marvinhagemeister
Copy link
Contributor

This PR adds a new --unstable-node-globals flag to expose Node globals by default.

Fixes #26611

@bartlomieju bartlomieju added this to the 2.1.0 milestone Oct 29, 2024
@bartlomieju
Copy link
Member

Let's update hints added in #26610 to mention this flag.

@bartlomieju bartlomieju mentioned this pull request Oct 30, 2024
Merged
bartlomieju
bartlomieju requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as "request changes" to update hints for terminal errors on Node.js globals

bartlomieju
bartlomieju approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju enabled auto-merge (squash) November 14, 2024 12:32
@bartlomieju bartlomieju merged commit de34c7e into main Nov 14, 2024
17 checks passed
@bartlomieju bartlomieju deleted the unstable-node-globals branch November 14, 2024 13:11
@redradist
Copy link

With this PR it looks like a global variable process, could be hidden behind this flag, see #26549

@dsherret dsherret mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Add --unstable-node-globals flag
3 participants
@marvinhagemeister @bartlomieju @redradist