Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): auto-import completions from byonm dependencies #26680

Merged
merged 9 commits into from
Nov 6, 2024
Merged

feat(lsp): auto-import completions from byonm dependencies #26680

merged 9 commits into from
Nov 6, 2024
+344 −105

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Nov 1, 2024 •
edited
Loading

@nayeemrmn nayeemrmn changed the title feat(lsp): auto-import completions from npm dependencies feat(lsp): auto-import completions from byonm dependencies Nov 5, 2024
@nayeemrmn nayeemrmn marked this pull request as ready for review November 5, 2024 12:11
nathanwhit
nathanwhit approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheGoatedDev
Copy link

Legends have been waiting for this, LGTM

nathanwhit
nathanwhit reviewed Nov 5, 2024
View reviewed changes
cli/lsp/tsc.rs Outdated Show resolved Hide resolved
@nayeemrmn nayeemrmn merged commit 5088b25 into denoland:main Nov 6, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-npm-auto-import branch November 6, 2024 08:23
littledivy pushed a commit that referenced this pull request Nov 10, 2024
@nayeemrmn @littledivy
feat(lsp): auto-import completions from byonm dependencies (#26680)
9f6fb5e
@pandapaul pandapaul mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno lsp auto-importing does not work Auto-import suggestions for npm libraries are not provided
3 participants
@nayeemrmn @TheGoatedDev @nathanwhit