Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): preserve comments in doc tests #26828

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

magurotuna
Copy link
Member

This commit makes comments in code snippets in JSDoc or markdown preserved when they are executed as tests. In particular, this is needed to get TypeScript special comments such as @ts-ignore or @ts-expect-error to work correctly.

Fixes #26728

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magurotuna magurotuna merged commit 15fae19 into denoland:main Nov 14, 2024
17 checks passed
@magurotuna magurotuna deleted the magurotuna/doc-test-ts-directive branch November 14, 2024 05:04
@laurence-myers
Copy link

Thank you, @magurotuna 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno check --doc does not respect @ts-expect-error directives in JSDoc examples
3 participants