Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(windows): delay load webgpu and some other dlls #26917

Merged
merged 3 commits into from
Nov 18, 2024
Merged

perf(windows): delay load webgpu and some other dlls #26917

merged 3 commits into from
Nov 18, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Nov 18, 2024 •
edited
Loading

Before: ~100ms, After: ~40ms for a hello world

Closes #26914

crowlKats
crowlKats approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@dsherret dsherret enabled auto-merge (squash) November 18, 2024 19:11
@dsherret dsherret changed the title perf(windows): delay loading webgpu and some other dlls perf(windows): delay load webgpu and some other dlls Nov 18, 2024
@dsherret dsherret disabled auto-merge November 18, 2024 19:12
@dsherret dsherret enabled auto-merge (squash) November 18, 2024 19:12
@dsherret dsherret merged commit 19bbf83 into denoland:main Nov 18, 2024
17 checks passed
@dsherret dsherret deleted the perf_windows_delay_loading_dlls branch November 18, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno execution on Windows is much slower due to WebGPU
2 participants
@dsherret @crowlKats