fix(compile): be more deterministic when compiling the same code in different directories #27395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
dsherret
added
ci-draft
bartlomieju
approved these changes
Dec 19, 2024
| None | ||
| }; | ||
| let mut source_maps = Vec::with_capacity(graph.specifiers_count()); | ||
| // todo(dsherret): transpile in parallel |
There was a problem hiding this comment.
I'll implement it sometime I'm in the code soon.
| } else { | ||
| self.shared.source_maps.get(file_name) | ||
| } | ||
| // todo(https://github.com/denoland/deno_core/pull/1007): don't clone |
There was a problem hiding this comment.
Should we release deno_core before landing this PR?
There was a problem hiding this comment.
I think it's fine to not wait.
Comment on lines
+241
to
+255
| builder.append_le( | ||
| self | ||
| .data | ||
| .iter() | ||
| .map(|(_, data, maybe_transpiled)| { | ||
| 1 + 4 | ||
| + (data.len() as u64) | ||
| + 1 | ||
| + match maybe_transpiled { | ||
| Some(transpiled) => 4 + (transpiled.len() as u64), | ||
| None => 0, | ||
| } | ||
| }) | ||
| .sum::<u64>(), | ||
| ); |
There was a problem hiding this comment.
This serialization is now quite complex, I'm starting to feel we should add some unit tests for it
There was a problem hiding this comment.
Also have you considered using serde_bincode instead of hand rolling it?
There was a problem hiding this comment.
I think it's ok. If there were any issues with it then the integration tests would fail.
I think this is more clear what's going on and allows for lazily deserializing certain parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionaly, this no longer unnecessarily stores the source twice for file specifiers and fixes some sourcemap issues.
Closes #27284