Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/fs): do not throw for bigint ctime/mtime/atime #27453

Merged
merged 3 commits into from
Dec 23, 2024
Merged

fix(ext/fs): do not throw for bigint ctime/mtime/atime #27453

merged 3 commits into from
Dec 23, 2024
+4 −3

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Dec 23, 2024 •
edited
Loading

fixes #27286
fixes #27443

dsherret
dsherret approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k
Copy link
Member Author

kt3k commented Dec 23, 2024

Notes:

These 3 fields are u64 in Rust struct

deno/ext/fs/ops.rs

Lines 1846 to 1852 in e6869d7

mtime: u64,
atime_set: bool,
atime: u64,
birthtime_set: bool,
birthtime: u64,
ctime_set: bool,
ctime: u64,

u64 fields can be serialized to BigInt if the value exceeds MAX_SAFE_INTEGER
https://github.com/denoland/deno_core/blob/f43085b91cd7a6b4ae6ae4efc041bf96bae3961f/serde_v8/ser.rs#L445-L454

@kt3k kt3k merged commit 2e58e08 into denoland:main Dec 23, 2024
17 checks passed
@kt3k kt3k deleted the fix-ctime-big-int branch December 23, 2024 04:56
dsherret pushed a commit that referenced this pull request Jan 9, 2025
@kt3k @dsherret
fix(ext/fs): do not throw for bigint ctime/mtime/atime (#27453)
5c4dd74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kt3k @dsherret