Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flatbuffers compile support #2795

Closed
wants to merge 2 commits into from
Closed

Remove flatbuffers compile support #2795

wants to merge 2 commits into from

Commits on Aug 20, 2019

  1. Add generated flatbuffer code to repo 

    This is split into a seperate commit so it's easier to see the
non-generated diff. This commit doesn't actually make use of the new
files and likely the build is broken on this commit due to linting.
    @ry
    ry committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    ddaa997 View commit details
    Browse the repository at this point in the history

  2. Remove flatbuffers compile support 

    This commit checks into the repo the two generated files
  cli/msg_generated.rs
  js/msg_generated.js
And removes support for automatically building them from the build.

This is further simplifications in order to allow the cli crate to build
without gn/ninja. See denoland#2608.
    @ry
    ry committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    733cb3a View commit details
    Browse the repository at this point in the history