Declare globals explicitly in lib.deno_runtime.d.ts

[nayeemrmn]

Fixes #2888.

I added export {}; (see comment and microsoft/TypeScript#19545). Everything global is in a declare global {} block.

@ry Not sure how I'd test this.

[kitsonk]

Can we hold off on this, until we restore the automatic library generation? See #2868.

Library files should not be UMD .d.ts files. They need to follow the pattern of other library files. I understand the problem, and we can address it as part of #2868, which is that we need better names for some of the namespaces we have to avoid unintentional userland collisions.

[nayeemrmn]

@kitsonk Makes sense, I agree in that case.

we need better names for some of the namespaces we have to avoid unintentional userland collisions.

As far as I can tell, these namespaces only hold local aliases used to specify the actual global stuff above. Are you sure there's no way to to properly internalise them? If not, could they all go in Deno, like a Deno.internal namespace or something? That way we keep our compatibility. https://www.typescriptlang.org/docs/handbook/declaration-files/library-structures.html#preventing-name-conflicts

[nayeemrmn]

@ry Can you cherry-pick 7b333d7? That's going to bug me.

[kitsonk]

@nayeemrmn yeah, that might be possible too... It had crossed my mind, but I dismissed it, but it actually makes sense that both functional code and types specific to Deno exist in the Deno namespace.