Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support load yaml/yml prettier config #3370

Merged
merged 1 commit into from
Nov 19, 2019
Merged

support load yaml/yml prettier config #3370

merged 1 commit into from
Nov 19, 2019

Conversation

axetroy
Copy link
Contributor

@axetroy axetroy commented Nov 18, 2019 •
edited
Loading

This is a supplement to #3346 (comment)

ry
ry approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm not so happy that "deno fmt" now depends on this a large yaml parser now. But maybe that can be fixed in the future.

@ry ry merged commit 00aa409 into denoland:master Nov 19, 2019
@axetroy axetroy deleted the fmt_prettierrc_yaml branch November 19, 2019 02:18
@axetroy
Copy link
Contributor Author

axetroy commented Nov 19, 2019 •
edited
Loading

LGTM - I'm not so happy that "deno fmt" now depends on this a large yaml parser now. But maybe that can be fixed in the future.

Maybe we can dynamically import toml/yaml parser.

This reduces the amount of loading too much at once.

Because not every time demo fmt command needs them, there is no need to declare it at the top.

bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
@axetroy @bartlomieju
support load yaml/yml prettier config (denoland#3370)
19e17fa
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@axetroy @ry
support load yaml/yml prettier config (denoland/deno#3370)
346d8a3
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@axetroy @ry
support load yaml/yml prettier config (denoland/deno#3370)
0013163
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@axetroy @caspervonb
support load yaml/yml prettier config (denoland/deno#3370)
da535a8
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@axetroy @caspervonb
support load yaml/yml prettier config (denoland/deno#3370)
4dd24a7
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@axetroy @caspervonb
support load yaml/yml prettier config (denoland/deno#3370)
f3d7508
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@axetroy @caspervonb
support load yaml/yml prettier config (denoland/deno#3370)
6728f2b
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@axetroy @caspervonb
support load yaml/yml prettier config (denoland/deno#3370)
12ee882
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@axetroy @denobot
support load yaml/yml prettier config (denoland/deno#3370)
318ca4d
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@axetroy @denobot
support load yaml/yml prettier config (denoland/deno#3370)
ad98587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axetroy @ry