feat: native plugins

.github/workflows/ci.yml

@@ -129,6 +129,7 @@ jobs:
       - name: Test debug
         if: matrix.kind == 'test_debug'
         run: |
+          cargo build --locked -p test_native_plugin
           echo ::set-env name=DENO_BUILD_MODE::debug
           cargo test --locked --all-targets
 

Cargo.toml

@@ -4,4 +4,5 @@ members = [
   "core",
   "tools/hyper_hello",
   "deno_typescript",
+  "cli/tests/test_native_plugin"
 ]

cli/Cargo.toml

@@ -31,6 +31,7 @@ base64 = "0.11.0"
 byteorder = "1.3.2"
 clap = "2.33.0"
 dirs = "2.0.2"
+dlopen = "0.1.8"
 futures = { version = "0.3", features = [ "compat", "io-compat" ] }
 http = "0.1.19"
 hyper = "0.12.35"

cli/deno_error.rs

@@ -6,6 +6,7 @@ pub use crate::msg::ErrorKind;
 use deno::AnyError;
 use deno::ErrBox;
 use deno::ModuleResolutionError;
+use dlopen::Error as DlopenError;
 use http::uri;
 use hyper;
 use reqwest;
@@ -287,6 +288,19 @@ mod unix {
   }
 }
 
+impl GetErrorKind for DlopenError {
+  fn kind(&self) -> ErrorKind {
+    use dlopen::Error::*;
+    match self {
+      NullCharacter(_) => ErrorKind::Other,
+      OpeningLibraryError(e) => GetErrorKind::kind(e),
+      SymbolGettingError(e) => GetErrorKind::kind(e),
+      NullSymbol => ErrorKind::Other,
+      AddrNotMatchingDll(e) => GetErrorKind::kind(e),
+    }
+  }
+}
+
 impl GetErrorKind for dyn AnyError {
   fn kind(&self) -> ErrorKind {
     use self::GetErrorKind as Get;
@@ -320,6 +334,7 @@ impl GetErrorKind for dyn AnyError {
           .downcast_ref::<serde_json::error::Error>()
           .map(Get::kind)
       })
+      .or_else(|| self.downcast_ref::<DlopenError>().map(Get::kind))
       .or_else(|| unix_error_kind(self))
       .unwrap_or_else(|| {
         panic!("Can't get ErrorKind for {:?}", self);

cli/flags.rs

@@ -48,6 +48,7 @@ pub struct DenoFlags {
   pub net_whitelist: Vec<String>,
   pub allow_env: bool,
   pub allow_run: bool,
+  pub allow_native: bool,
   pub allow_hrtime: bool,
   pub no_prompts: bool,
   pub no_fetch: bool,
@@ -105,6 +106,11 @@ fn add_run_args<'a, 'b>(app: App<'a, 'b>) -> App<'a, 'b> {
         .long("allow-run")
         .help("Allow running subprocesses"),
     )
+    .arg(
+      Arg::with_name("allow-native")
+        .long("allow-native")
+        .help("Allow opening native plugins"),
+    )
     .arg(
       Arg::with_name("allow-hrtime")
         .long("allow-hrtime")
@@ -843,6 +849,9 @@ fn parse_run_args(mut flags: DenoFlags, matches: &ArgMatches) -> DenoFlags {
   if matches.is_present("allow-run") {
     flags.allow_run = true;
   }
+  if matches.is_present("allow-native") {
+    flags.allow_native = true;
+  }
   if matches.is_present("allow-hrtime") {
     flags.allow_hrtime = true;
   }
@@ -853,6 +862,7 @@ fn parse_run_args(mut flags: DenoFlags, matches: &ArgMatches) -> DenoFlags {
     flags.allow_run = true;
     flags.allow_read = true;
     flags.allow_write = true;
+    flags.allow_native = true;
     flags.allow_hrtime = true;
   }
   if matches.is_present("no-fetch") {
@@ -970,6 +980,7 @@ pub fn flags_from_vec(
       flags.allow_run = true;
       flags.allow_read = true;
       flags.allow_write = true;
+      flags.allow_native = true;
       flags.allow_hrtime = true;
       let code: &str = eval_match.value_of("code").unwrap();
       argv.extend(vec![code.to_string()]);
@@ -1138,6 +1149,7 @@ pub fn flags_from_vec(
       flags.allow_run = true;
       flags.allow_read = true;
       flags.allow_write = true;
+      flags.allow_native = true;
       flags.allow_hrtime = true;
       argv.push(XEVAL_URL.to_string());
 
@@ -1181,6 +1193,7 @@ pub fn flags_from_vec(
       flags.allow_run = true;
       flags.allow_read = true;
       flags.allow_write = true;
+      flags.allow_native = true;
       flags.allow_hrtime = true;
       DenoSubcommand::Repl
     }
@@ -1340,6 +1353,7 @@ mod tests {
         allow_run: true,
         allow_read: true,
         allow_write: true,
+        allow_native: true,
         allow_hrtime: true,
         ..DenoFlags::default()
       }
@@ -1490,6 +1504,7 @@ mod tests {
         allow_run: true,
         allow_read: true,
         allow_write: true,
+        allow_native: true,
         allow_hrtime: true,
         ..DenoFlags::default()
       }
@@ -1509,6 +1524,7 @@ mod tests {
         allow_run: true,
         allow_read: true,
         allow_write: true,
+        allow_native: true,
         allow_hrtime: true,
         ..DenoFlags::default()
       }
@@ -1536,6 +1552,7 @@ mod tests {
         allow_run: true,
         allow_read: true,
         allow_write: true,
+        allow_native: true,
         allow_hrtime: true,
         ..DenoFlags::default()
       }

cli/js/deno.ts

@@ -75,6 +75,7 @@ export {
 } from "./permissions.ts";
 export { truncateSync, truncate } from "./truncate.ts";
 export { FileInfo } from "./file_info.ts";
+export { openPlugin } from "./native_plugins.ts";
 export { connect, dial, listen, Listener, Conn } from "./net.ts";
 export { dialTLS, listenTLS } from "./tls.ts";
 export { metrics, Metrics } from "./metrics.ts";

cli/js/dispatch.ts

@@ -1,6 +1,7 @@
 // Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
 import * as minimal from "./dispatch_minimal.ts";
 import * as json from "./dispatch_json.ts";
+import { AsyncHandler } from "./native_plugins.ts";
 
 // These consts are shared with Rust. Update with care.
 export let OP_READ: number;
@@ -66,6 +67,16 @@ export let OP_CWD: number;
 export let OP_FETCH_ASSET: number;
 export let OP_DIAL_TLS: number;
 export let OP_HOSTNAME: number;
+export let OP_OPEN_NATIVE_PLUGIN: number;
+
+const NATIVE_PLUGIN_ASYNC_HANDLER_MAP: Map<number, AsyncHandler> = new Map();
+
+export function setPluginAsyncHandler(
+  opId: number,
+  handler: AsyncHandler
+): void {
+  NATIVE_PLUGIN_ASYNC_HANDLER_MAP.set(opId, handler);
+}
 
 export function asyncMsgFromRust(opId: number, ui8: Uint8Array): void {
   switch (opId) {
@@ -109,6 +120,11 @@ export function asyncMsgFromRust(opId: number, ui8: Uint8Array): void {
       json.asyncMsgFromRust(opId, ui8);
       break;
     default:
-      throw Error("bad async opId");
+      const handler = NATIVE_PLUGIN_ASYNC_HANDLER_MAP.get(opId);
+      if (handler) {
+        handler(ui8);
+      } else {
+        throw Error("bad async opId");
+      }
   }
 }

cli/js/lib.deno_runtime.d.ts

@@ -967,6 +967,28 @@ declare namespace Deno {
    */
   export function truncate(name: string, len?: number): Promise<void>;
 
+  // @url js/native_plugins.d.ts
+
+  export interface AsyncHandler {
+    (msg: Uint8Array): void;
+  }
+
+  export interface NativePluginOp {
+    dispatch(
+      control: Uint8Array,
+      zeroCopy?: ArrayBufferView | null
+    ): Uint8Array | null;
+    setAsyncHandler(handler: AsyncHandler): void;
+  }
+
+  export interface NativePlugin {
+    ops: {
+      [name: string]: NativePluginOp;
+    };
+  }
+
+  export function openPlugin(filename: string): NativePlugin;
+
   // @url js/net.d.ts
 
   type Transport = "tcp";