Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get file and fileInfo concurrently #3486

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Get file and fileInfo concurrently #3486

merged 1 commit into from
Dec 12, 2019

Conversation

starkwang
Copy link
Contributor

Now we get the file and fileInfo sequentially. This change is to make it concurrently, which reduces time cost from open() + stat() to max(open(), stat())

@claassistantio
Copy link

claassistantio commented Dec 12, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ry
ry approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit df7d828 into denoland:master Dec 12, 2019
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
@starkwang @bartlomieju
file_server: get file and fileInfo concurrently (denoland#3486)
895b8a2
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@starkwang @ry
file_server: get file and fileInfo concurrently (denoland/deno#3486)
b6e4e52
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@starkwang @ry
file_server: get file and fileInfo concurrently (denoland/deno#3486)
883fcdd
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@starkwang @caspervonb
file_server: get file and fileInfo concurrently (denoland/deno#3486)
b7714e7
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@starkwang @caspervonb
file_server: get file and fileInfo concurrently (denoland/deno#3486)
0e408a3
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@starkwang @caspervonb
file_server: get file and fileInfo concurrently (denoland/deno#3486)
c4621b5
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@starkwang @caspervonb
file_server: get file and fileInfo concurrently (denoland/deno#3486)
a27f19c
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@starkwang @caspervonb
file_server: get file and fileInfo concurrently (denoland/deno#3486)
2118d59
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@starkwang @denobot
file_server: get file and fileInfo concurrently (denoland/deno#3486)
303d534
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@starkwang @denobot
file_server: get file and fileInfo concurrently (denoland/deno#3486)
d23341c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@starkwang @claassistantio @ry