Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix permission errors are swallowed by fs.copy() #3504

Merged
merged 2 commits into from
Dec 18, 2019
Merged

fix permission errors are swallowed by fs.copy() #3504

merged 2 commits into from
Dec 18, 2019

Conversation

axetroy
Copy link
Contributor

@axetroy axetroy commented Dec 15, 2019

ref: #3483
and refactor ensureDir() and ensureFile() make it more clearer

@axetroy axetroy mentioned this pull request Dec 15, 2019
Closed
ry
ry approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit ef30d37 into denoland:master Dec 18, 2019
@axetroy axetroy deleted the refactor_ensure_dir branch December 18, 2019 14:46
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
@axetroy @bartlomieju
fix permission errors are swallowed by fs.copy() (denoland#3504)
90075fb
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@axetroy @ry
fix permission errors are swallowed by fs.copy() (denoland/deno#3504)
be2e93e
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@axetroy @ry
fix permission errors are swallowed by fs.copy() (denoland/deno#3504)
d8874da
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@axetroy @caspervonb
fix permission errors are swallowed by fs.copy() (denoland/deno#3504)
792a540
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@axetroy @caspervonb
fix permission errors are swallowed by fs.copy() (denoland/deno#3504)
668d2bb
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@axetroy @caspervonb
fix permission errors are swallowed by fs.copy() (denoland/deno#3504)
0aab65a
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@axetroy @caspervonb
fix permission errors are swallowed by fs.copy() (denoland/deno#3504)
1f7cdec
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@axetroy @caspervonb
fix permission errors are swallowed by fs.copy() (denoland/deno#3504)
9fe1003
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@axetroy @denobot
fix permission errors are swallowed by fs.copy() (denoland/deno#3504)
834677c
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@axetroy @denobot
fix permission errors are swallowed by fs.copy() (denoland/deno#3504)
e24c39a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axetroy @ry