Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment: Remove test runner hack #3671

Closed
wants to merge 1 commit into from
Closed

Experiment: Remove test runner hack #3671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 1 addition & 62 deletions std/testing/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,28 +116,6 @@ export interface RunTestModulesOptions extends RunTestsOptions {
allowNone?: boolean;
}

/**
* Renders test file that will be run.
*
* It's done to optimize compilation of test files, because
* dynamically importing them one by one takes very long time.
* @TODO(bartlomieju): try to optimize compilation by reusing same compiler host
* multiple times
* @param testModules
*/
function renderTestFile(testModules: string[]): string {
let testFile = "";

for (const testModule of testModules) {
// NOTE: this is intentional that template string is not used
// because of TS compiler quirkness of trying to import it
// rather than treating it like a variable
testFile += 'import "' + testModule + '"\n';
}

return testFile;
}

/**
* Import the specified test modules and run their tests as a suite.
*
Expand Down Expand Up @@ -175,9 +153,8 @@ export async function runTestModules({
disableLog = false
}: RunTestModulesOptions = {}): Promise<void> {
let moduleCount = 0;
const testModules = [];
for await (const testModule of findTestModules(include, exclude)) {
testModules.push(testModule);
await import(testModule);
moduleCount++;
}

Expand All @@ -191,44 +168,6 @@ export async function runTestModules({
return;
}

// Create temporary test file which contains
// all matched modules as import statements.
const testFile = renderTestFile(testModules);
// Select where temporary test file will be stored.
// If `DENO_DIR` is set it means that user intentionally wants to store
// modules there - so it's a sane default to store there.
// Fallback is current directory which again seems like a sane default,
// user is probably working on project in this directory or even
// cd'ed into current directory to quickly run test from this directory.
const root = Deno.env("DENO_DIR") || Deno.cwd();
const testFilePath = join(root, ".deno.test.ts");
const data = new TextEncoder().encode(testFile);
await Deno.writeFile(testFilePath, data);

// Import temporary test file and delete it immediately after importing so it's not cluttering disk.
//
// You may think that this will cause recompilation on each run, but this actually
// tricks Deno to not recompile files if there's no need.
// Eg.
// 1. On first run of $DENO_DIR/.deno.test.ts Deno will compile and cache temporary test file and all of its imports
// 2. Temporary test file is removed by test runner
// 3. On next test run file is created again. If no new modules were added then temporary file contents are identical.
// Deno will not compile temporary test file again, but load it directly into V8.
// 4. Deno starts loading imports one by one.
// 5. If imported file is outdated, Deno will recompile this single file.
let err;
try {
await import(`file://${testFilePath}`);
} catch (e) {
err = e;
} finally {
await Deno.remove(testFilePath);
}

if (err) {
throw err;
}

if (!disableLog) {
console.log(`Found ${moduleCount} matching test modules.`);
}
Expand Down