refactor: remove unneeded ErrorKinds #3936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
changed the title
bartlomieju
changed the title
ry
reviewed
Feb 19, 2020
ry
reviewed
Feb 19, 2020
ry
reviewed
Feb 19, 2020
ry
reviewed
Feb 19, 2020
ry
reviewed
Feb 19, 2020
ry
reviewed
Feb 19, 2020
cli/deno_error.rs
Outdated
| @@ -252,6 +247,8 @@ impl GetErrorKind for DlopenError { | |||
| } | |||
| } | |||
|
|
|||
| // NOTE(bartlomieju): seems this is necessary - can't use ErrBox here | |||
| // TODO(bartlomieju): ultimately this should be rewritten to `RuntimeError`? | |||
| impl GetErrorKind for dyn AnyError { | |||
| fn kind(&self) -> ErrorKind { | |||
There was a problem hiding this comment.
I don't think this impl is necessary. I suggest:
fn kind(&self) -> ErrorKind {
unreachable!()
}There was a problem hiding this comment.
Not really, it seems necessary, tried to remove that and doesn't work. Need to figure this out
ry
reviewed
Feb 19, 2020
ry
reviewed
Feb 19, 2020
bartlomieju
commented
Feb 19, 2020
|
@ry I'd prefer to land this PR as is if CI goes green. We should be able to rewrite the rest tomorrow. |
ry
requested changes
Feb 20, 2020
ry
approved these changes
Feb 21, 2020
This was referenced Feb 23, 2020
Closed
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3662
DenoError.OtherwithErrorDenoError.UrlParse,DenoError.InvalidPathandDenoError.ImportMissingPrefixwithURIErrorDenoError.HttpwithHttpError(?) - the same error thatfetchthrowsIoError(?)NotFoundPermissionDeniedConnectionRefusedConnectionResetConnectionAbortedNotConnectedAddrInUseAddrNotAvailableBrokenPipeAlreadyExistsWouldBlock- shouldn't be usedInvalidInput-TypeErrorInvalidData-TypeErrorError?)TimedOutInterrupted- shouldn't be usedWriteZeroUnexpectedEofBadResourceInvalidSeekModewithTypeErrorTooLargewithErrorUnixErrorwithSystemError(?) -> explode that to ERRNO, map ERRNO to Deno defined errors, if one does not exist then panicDiagnosticandJSError