-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added browser chat example #4022
Conversation
keroxp
commented
Feb 17, 2020
Cool! I realize we don't have tests in the examples directory - but we should - I wonder if you'd be able to provide a basic test for this? Otherwise it's quite likely it will break... |
I've realized that remote modules can't serve file that located on the remote server...
It won't work after merged :( |
@keroxp Can you use |
@ry No, maybe. There is no way to "open" remote file from local. // deno -A https://deno.land/std/example/chat/server.ts -> https://deno.land/std/examples/chat/index.html
// deno -A ./server.ts -> file:///src/deno/std/examples/chat/server.ts
const f = new URL("./index.html", import.meta.url).href;
fetch(f).then(resp => req.respond(resp)) Code above worked for |
Additionally I found another bug #4038 |
@ry I fixed those problems by hacky way. Would you see the change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks - LGTM