Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update manual about how to run tests for std #4462

Merged
merged 3 commits into from
Mar 24, 2020
Merged

docs: update manual about how to run tests for std #4462

merged 3 commits into from
Mar 24, 2020

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented Mar 22, 2020

No description provided.

ry
ry reviewed Mar 23, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just cargo test std works

@uki00a
Copy link
Contributor Author

uki00a commented Mar 23, 2020 •
edited
Loading

@ry

cd std && cargo run -- test -A and cargo test std are not exactly the same.

When running cargo test std, some integration tests that include std in the name are also run.

$ cargo test std
    Finished test [unoptimized + debuginfo] target(s) in 0.12s
     Running target/debug/deps/deno-fd719d619b8bb339

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 202 filtered out

     Running target/debug/deps/deno-e3b2d9b2984f60aa

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/integration_tests-cc919576e0cf58fb

running 6 tests
test fmt_stdin_error ... ok
test fmt_stdin ... ok
test fmt_stdin_check_not_formatted ... ok
test fmt_stdin_check_formatted ... ok
test unbuffered_stdout ... ok
test unbuffered_stderr ... ok

test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 170 filtered out

     Running target/debug/deps/std_tests-052076291d27cef0

running 1 test
Compile file:///home/uki00a/work/deno/std/.deno.test.ts
test tests::std_tests ... test tests::std_tests has been running for over 60 seconds

running 809 tests
test ioStringWriter ... ok (3ms)
test [io/tuil] copyBytes ... ok (2ms)
...

@ry
Copy link
Member

ry commented Mar 23, 2020 •
edited
Loading

True, it should be cargo test std_tests.

It's better to run from cargo because 1) it ensures any changes made in the deno executable are correctly used 2) it starts tools/http_server.py which is needed by some of the std tests.

@uki00a uki00a requested a review from ry March 23, 2020 19:59
bartlomieju
bartlomieju requested changes Mar 24, 2020
View reviewed changes
std/manual.md Outdated
@@ -1588,7 +1588,10 @@ Test `std/`:

```bash
cd std
cargo run -- -A testing/runner.ts --exclude "**/testdata"
cargo run -- test -A
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this command

@uki00a uki00a requested a review from bartlomieju March 24, 2020 14:14
bartlomieju
bartlomieju approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @uki00a

@bartlomieju bartlomieju merged commit b2478f3 into denoland:master Mar 24, 2020
@uki00a uki00a deleted the how-to-run-tests-for-std branch March 24, 2020 21:54
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 29, 2020
@dubiousjim
Merge remote-tracking branch 'denoland/master' into middle2h+
c2c2f2e 
* denoland/master: (35 commits)
  Ignore flaky test cafile_info (denoland#4517)
  fix(inspector): proper error message on port collision (denoland#4514)
  feat: Added colors to doc output (denoland#4518)
  v0.38.0
  feat: Add "deno doc" subcommand (denoland#4500)
  Update to Prettier 2 and use ES Private Fields (denoland#4498)
  upgrade: dprint 0.9.6 (denoland#4509)
  upgrade: rusty_v8 to v0.3.9 (denoland#4505)
  feat: Support Inspector / Chrome Devtools (denoland#4484)
  Improve isatty and kill API docs; Deno.kill() - throw on Windows (denoland#4497)
  refactor: rename ConsoleOptions to InspectOptions (denoland#4493)
  upgrade: dprint 0.9.5 (denoland#4491)
  feat: window.close() (denoland#4474)
  errors: replace .lines with explicit .split newline (denoland#4483)
  doc: improve various API docs and include examples (denoland#4486)
  hide source line if error message longer than 150 chars (denoland#4487)
  fix: add fsEvent notify::Error casts (denoland#4488)
  feat: add queueMicrotask to d.ts (denoland#4477)
  Revert "avoid using same port number for test (denoland#4147)"
  docs: update manual about how to run tests for std (denoland#4462)
  ...
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@uki00a
docs: update manual about how to run tests for std (denoland/deno#4462)
baa8fe2
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@uki00a
docs: update manual about how to run tests for std (denoland/deno#4462)
34dc08e
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@uki00a @caspervonb
docs: update manual about how to run tests for std (denoland/deno#4462)
ba9cd74
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@uki00a @caspervonb
docs: update manual about how to run tests for std (denoland/deno#4462)
9825ca9
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@uki00a @caspervonb
docs: update manual about how to run tests for std (denoland/deno#4462)
f53b611
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@uki00a @caspervonb
docs: update manual about how to run tests for std (denoland/deno#4462)
1d53df1
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@uki00a @caspervonb
docs: update manual about how to run tests for std (denoland/deno#4462)
1137af0
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@uki00a @denobot
docs: update manual about how to run tests for std (denoland/deno#4462)
f267ef0
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@uki00a @denobot
docs: update manual about how to run tests for std (denoland/deno#4462)
182030c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@ry ry Awaiting requested review from ry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uki00a @ry @bartlomieju