-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Op crate for Web APIs #6906
Op crate for Web APIs #6906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I've released this to https://crates.io/crates/deno_web
Is it possible to use something like this in the crate? pub fn init(isolate: &mut deno_core::CoreIsolate) {
deno_core::js_check(
isolate.execute("00_dom_exception.js", include_str!("00_dom_exception.js")),
);
deno_core::js_check(
isolate.execute("01_event.js", include_str!("01_event.js")),
);
deno_core::js_check(
isolate.execute("08_text_encoding.js", include_str!("08_text_encoding.js")),
);
} |
Sure, but I'd rather punt on it a bit more. Let's revisit this topic after moving more APIs to this crate. |
Let’s just leave the duplicated tests for now? I am worried about losing the type checks in them. |
This reverts commit 90397b2.
No description provided.