feat(doc): Added uptime function for Deno #8540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm closing because for whatever reason, boottime is only implemented for non-Windows systems. While there is a pending pull request on sys-info that will hopefully resolve this issue (FillZpp/sys-info-rs#48), I don't see much point in keeping this PR open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides uptime function for issue #3802 . I haven't added tests yet, because I'm not sure how to test uptime. For example, the test loadavgSuccess merely checks whether an array of 3 is given by Deno.loadavg; it doesn't actually check the loadtimes.
As it turns out in issue #8357 , heim is NOT needed to implement uptime. sysinfo already provides a function that can give the uptime called boottime, as I found in this issue.
Note: this is still a WIP, even though it should hopefully be mostly done.