fix: align DOMException API to the spec and add web platform testing of it. #9106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
force-pushed
the
fix/domexception-wpt
branch
from
9326d5a to
72f873a
Compare
|
This passes WPT suites, but an uncaught DOMException doesn't show the stack trace now. I'm investigating the handling of uncaught error in |
kt3k
force-pushed
the
fix/domexception-wpt
branch
from
88917ce to
0d40a05
Compare
|
Restored the original behavior when thrown as uncaught error, but as a result I have to skip the case Now it's ready for review. |
|
Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is part of #9001.
This PR adds web platform testing of DOMException API and align our implementation to pass it.