Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dyn imports exceeding call stack size #1058

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

littledivy
Copy link
Member

Fixes #1050

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.66%. Comparing base (0c7f83e) to head (894afd0).
Report is 245 commits behind head on main.

Files with missing lines Patch % Lines
core/runtime/bindings.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   81.43%   81.66%   +0.22%     
==========================================
  Files          97      101       +4     
  Lines       23877    27849    +3972     
==========================================
+ Hits        19445    22742    +3297     
- Misses       4432     5107     +675     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, LGTM

@littledivy littledivy merged commit cce028f into denoland:main Jan 24, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in dynamic import
3 participants