feat: Add ImportAssertionsSupport #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Jul 30, 2024
core/runtime/jsruntime.rs
Outdated
Comment on lines
606
to
621
| eprintln!("⚠️ Import assertions are deprecated. Use `with` keyword, instead of 'assert' keyword."); | ||
| if let Some(specifier) = maybe_script_resource_name { | ||
| if let Some(source_line) = maybe_source_line { | ||
| eprintln!(); | ||
| eprintln!("{}", source_line.to_rust_string_lossy(scope)); | ||
| eprintln!(); | ||
| eprintln!("{:0width$}^^^^^^", " ", width = start_column); | ||
| } | ||
| eprintln!( | ||
| " at {}:{}:{}", | ||
| specifier.to_rust_string_lossy(scope), | ||
| maybe_line_number.unwrap(), | ||
| start_column | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
This prints a message like:
⚠️ Import assertions are deprecated. Use `with` keyword, instead of 'assert' keyword.
import data from "./data.json" assert { type: "json" };
^^^^^^
at file:///Users/ib/dev/deno/foo.js:1:31
Kinda feel we might want to reuse it in the CLI, just print it in yellow (with a Warning: prefix). Need to figure out how to easily share it
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 81.43% 81.52% +0.08%
==========================================
Files 97 98 +1
Lines 23877 24919 +1042
==========================================
+ Hits 19445 20316 +871
- Misses 4432 4603 +171 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for denoland/deno#24743.