fix: preserve cped in dynamic imports #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
force-pushed
the
preserve-cped-import
branch
from
a632e56
to
38013cb
Compare
bartlomieju
reviewed
Aug 29, 2024
There was a problem hiding this comment.
So FYI, real AsyncContext will likely not do referrer based inheritance of the context, but instead will run the module evaluation (for all modules) in the root context.
This is because otherwise the context used in the module is racy - it's unfortunately Node does something different with ALS here.
|
I don't think there's a good way to test this in core without rewriting the module resolver that the testing infra uses to be much more complex... but I will add a test to deno. |
bartlomieju
approved these changes
Sep 10, 2024
devsnek
added a commit
to denoland/deno
that referenced
this pull request
Sep 12, 2024
The fix is in denoland/deno_core#888 Fixes: #25275 Signed-off-by: snek <snek@deno.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for denoland/deno#25275
This code is like hacks on top of hacks, but basically save & restore cped in the dynamic import flow.