-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Escape reserved JSON characters before bundling into JS file #84
fix: Escape reserved JSON characters before bundling into JS file #84
Conversation
Can I ask for actions reapproval? |
@kamilogorek done |
Uh, did |
Should be good now |
@kamilogorek Windows CI is still not happy |
Updated. I didnt pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for looking into this Kamil!
Fixes denoland/deno#14012 and removes unnecessary line-ending from the processed output, as before the trimming, it always ended up looking like this:
Escaping is done using https://docs.rs/escape8259/ and verified correctness with the https://www.rfc-editor.org/rfc/rfc8259 itself. I didn't see a point vendoring such a small library, but if necessary, we can do that.