Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deno_graph 0.84 #203

Merged
merged 1 commit into from
Dec 3, 2024
Merged

refactor: deno_graph 0.84 #203

merged 1 commit into from
Dec 3, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Oct 28, 2024 •
edited
Loading

Analyzes require calls and parses with parse_program instead of parse_module.

@dsherret dsherret requested a review from arnauorriols October 28, 2024 21:39
@arnauorriols
Copy link
Member

@dsherret Can you elaborate what's to be expected from this upgrade? I assume it has to do with Cjs support but I'm not sure the extend of it

@dsherret
Copy link
Member Author

@arnauorriols I updated the PR description. It analyzes require and parses with parse_program instead of parse_module so that it's easy to quickly see if the file has anything in it that makes it definitely esm.

@dsherret dsherret merged commit a94963e into denoland:main Dec 3, 2024
2 checks passed
@dsherret dsherret deleted the refactor_deno_graph_0_84 branch December 3, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@arnauorriols arnauorriols Awaiting requested review from arnauorriols

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsherret @arnauorriols @lucacasonato