feat: upgrade swc_ecmascript to 0.137.0 #63
Conversation
|
|
||
| [[example]] | ||
| name = "eszip_load" | ||
| path = "src/examples/load.rs" |
There was a problem hiding this comment.
Removed because of circular dependency between eszip and deno_core (was getting an error upgrading a dependency). Opened #64
There was a problem hiding this comment.
Yikes, how can we alleviate it?
There was a problem hiding this comment.
Why does deno_core have a dep on eszip? (These examples are important, I'd like to keep them).
There was a problem hiding this comment.
I think it's not deno_core, but deno (for deno compile)
There was a problem hiding this comment.
But then why is that an issue? The examples only rely on deno_core, not deno.
There was a problem hiding this comment.
As discussed on discord, it was the once_cell dep being pinned in deno_core
| @@ -0,0 +1 @@ | |||
| {"version":3,"sources":["file:///b.ts"],"sourcesContent":["export const b = \"b\";\n"],"names":[],"mappings":"AAAA,MAAM,CAAC,KAAK,CAAC,CAAC,GAAG,CAAG"} | |||
There was a problem hiding this comment.
Swc changed its sourcemap output (which looks valid to me, but has more detail. I went through and looked at the changes). For this reason, I stored the old sourcemap output to compare to the existing eszip files in separate files here.
| @@ -827,16 +837,16 @@ mod tests { | |||
| let module = eszip.get_module("file:///main.ts").unwrap(); | |||
| assert_eq!(module.specifier, "file:///main.ts"); | |||
| let source = module.source().await; | |||
| assert_eq!(&*source, include_bytes!("./testdata/emit/main.ts")); | |||
| assert_matches_file!(source, "./testdata/emit/main.ts"); | |||
There was a problem hiding this comment.
These statements previously did not give good assertion errors. This is improved now. I used a macro instead of a function because then it says the line number for what assertion failed.
No description provided.