Pass page props to application wrapper #1153
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add a footer whose content changes based on the current route, but the application wrapper is only passed the component. This PR adds the
PageProps
under a newpage
property. I’m a bit confused about whether this is the right approach, though.render
currently setsprops
per the docs and declares it asRecord<string, unknown>
to pass safely toh
. Passing thoseprops
alongsideComponent
works and passes type checking, but I’m not sure whether there’s a reason for theunknown
or not, so I can’t tell whether I’ve broken something. (And I can’t run the tests because it keeps failing on account of the port being in use. No idea why. I’m on Windows, and I can see it succeeds in CI.)