feat: support passing signals as island props #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
force-pushed
the
signal_props
branch
from
e1808ce to
ee2f240
Compare
lucacasonato
force-pushed
the
signal_props
branch
from
ee2f240 to
b167538
Compare
lucacasonato
force-pushed
the
signal_props
branch
2 times, most recently
from
69e0e96 to
59d1a54
Compare
lucacasonato
force-pushed
the
new_deserializer
branch
from
5b1a8a4 to
93dbd61
Compare
lucacasonato
force-pushed
the
signal_props
branch
from
59d1a54 to
7ac8fc7
Compare
lucacasonato
force-pushed
the
signal_props
branch
from
7ac8fc7 to
6d4e7b3
Compare
lucacasonato
force-pushed
the
signal_props
branch
from
6d4e7b3 to
79388b5
Compare
lucacasonato
force-pushed
the
signal_props
branch
from
79388b5 to
97badfc
Compare
This commit adds support for passing signals to islands in component props. This is useful for passing around mutable state between islands. The signal's value needs to be serializable for this to work.
lucacasonato
force-pushed
the
signal_props
branch
from
97badfc to
465eb18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for passing signals to islands in component
props. This is useful for passing around mutable state between islands.
The signal's value needs to be serializable for this to work.
Closes #749
Depends on #1224