Skip to content

Commit

Permalink
Remove zlib dependency (#1058)
Browse files Browse the repository at this point in the history
Deno does its own snapshot compression using lz4 and zstd, so no need to
build zlib into V8. See denoland/deno#13320
  • Loading branch information
ry authored Aug 23, 2022
1 parent 88f7055 commit 169d5d6
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
[submodule "buildtools"]
path = buildtools
url = https://github.com/denoland/chromium_buildtools.git
[submodule "third_party/zlib"]
path = third_party/zlib
url = https://chromium.googlesource.com/chromium/src/third_party/zlib.git
[submodule "third_party/icu"]
path = third_party/icu
url = https://github.com/denoland/icu.git
3 changes: 3 additions & 0 deletions .gn
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ default_args = {
symbol_level = 1
use_debug_fission = false

# Deno does its own snapshot compression using lz4 and zstd.
v8_use_zlib = false
v8_enable_snapshot_compression = false

v8_enable_javascript_promise_hooks = true
v8_promise_internal_field_count = 1
v8_use_external_startup_data = false
Expand Down
1 change: 0 additions & 1 deletion third_party/zlib
Submodule zlib deleted from 9979c1

0 comments on commit 169d5d6

Please sign in to comment.