-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unknown argument: '-gno-inline-line-tables' #226
Comments
Looks like |
We could also provide a way to opt out of this flag. Note we have hacked chromium's build repository to add this flag: denoland/chromium_build@65d79729a |
I had hoped you could grab the latest clang:
But this seems to provide a clang which requires GLIBC (which wasn't the case in 0.29.0). |
@ry is there a way to un-hack the chromium_build from deno_src (I don't see |
@hayd I'm not sure what you mean, but deno_src is created here: |
Sorry for being unclear, I mean how do I edit that file to test this locally? (I wanted to just remove the '-gno-inline-line-tables' and confirm it would build.) |
@hayd check out denoland/chromium_build@65d79729a Essentially you'll want to revert that commit (or better, make it conditional), and update the build submodule in rusty_v8. |
Reverting to hayd@37c7578 (off of v0.1.0):
Am I doing something wrong in the revert? |
@hayd These are all symbols that have been removed from rusty_v8. You probably need to pull the 'deno' repo to get denoland/deno@8c3cd63. |
What I did: checked out 0.1.0 rusty_v8; cd build; reverted denoland/chromium_build@65d79729a; commit/push; then pointed Cargo.toml of deno 0.30.0 to my rusty_v8 branch 🤷♂ I will try this again! |
This did work for me, can -gno-inline-line-tables be behind a flag? |
@hayd Yes, do you know how to do that? You need to add a new "arg" to the We probably need to add a cargo feature to toggle it... We don't have an example of this yet. |
There is already the possibility to specify |
Thanks for the fix! I am still very confused at the glibc dependency (and how it plays in denoland/deno#3711 ) |
@hayd FYI: The newly released |
Thanks @chrmoritz I bumped to clang 10 and removed it in amazonlinux1 deno-docker (for aws lambda) and get the smaller binary 🥳. What was confusing was I able to undo it, using clang 9, and it still built! (it didn't use to) https://github.com/hayd/deno-docker/actions/runs/66067472 |
@hayd: Are you setting |
Wow, you're right... I'm shocked it's compatible! Since lambda tests still pass so looks like it isn't breaking anything. I wonder what this means wrt musl issues... |
I get this error when building deno from source (this used to work in 0.29.0):
Am I doing something wrong here?
xlink #200 (#49 and denoland/deno#3711)
The text was updated successfully, but these errors were encountered: