feat: allow v8::Data as a generic for get_*_from_snapshot_once #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
force-pushed
the
get_context_data_from_snapshot_once
branch
from
6b1a4d0 to
006e524
Compare
mmastrac
force-pushed
the
get_context_data_from_snapshot_once
branch
from
006e524 to
41c2470
Compare
dsherret
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8::DataisTryFrom<v8::Data, but the error isInfallibleso these methods didn't work for the generic typev8::Data.We can add a private trait that will allow us to work with
v8::Datain these APIs.