fix: let cppgc align to 16 bytes #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
approved these changes
Jan 3, 2025
| @@ -343,6 +344,11 @@ pub unsafe fn make_garbage_collected<T: GarbageCollected + 'static>( | |||
| heap: &Heap, | |||
| obj: T, | |||
| ) -> Ptr<T> { | |||
| const { | |||
| // max alignment in cppgc is 16 | |||
| assert!(std::mem::align_of::<T>() <= 16); | |||
There was a problem hiding this comment.
Suggested change
| assert!(std::mem::align_of::<T>() <= 16); | |
| assert!(std::mem::align_of::<T>() <= 16, "cppgc objects have a max alignment of 16"); |
| ) | ||
| }; | ||
|
|
||
| assert!(!pointer.is_null()); |
There was a problem hiding this comment.
Suggested change
| assert!(!pointer.is_null()); | |
| // Sanity check: this is already checked by the const assertion above. | |
| debug_assert!(!pointer.is_null()); |
littledivy
approved these changes
Jan 4, 2025
devsnek
force-pushed
the
fix-cppgc-align
branch
from
4bb46e1 to
0e02f31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cppgc supports exactly two alignments: 8 byte and 16 byte. We can support this by dispatching to a different base C++ class.
Fixes: #1676