Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todo: improve user page header #468

Closed
iuioiua opened this issue Sep 1, 2023 · 8 comments
Closed

todo: improve user page header #468

iuioiua opened this issue Sep 1, 2023 · 8 comments
Assignees
@roberto-morado
Labels
v1

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Sep 1, 2023

The current user page header looks like this:
Screenshot 2023-09-01 at 12 05 56 pm

I think it'd look nice if:

  • Everything was horizontally aligned to the centre - avatar image on the top, username and badge in the middle and GitHub link on the bottom
  • Avatar image was bigger

WDYT, @hashrock?
@iuioiua iuioiua added the v1 label Sep 1, 2023
@iuioiua iuioiua mentioned this issue Sep 1, 2023
Closed
7 tasks
@hashrock
Copy link
Contributor

hashrock commented Sep 1, 2023 •
edited
Loading

Yeah it would be great!

@roberto-morado
Copy link
Contributor

Assign me 👋

@roberto-morado
Copy link
Contributor

Which one do you prefer?

@iuioiua

Reference

Screenshot 2023-09-04 at 9 43 18 PM

Alternatives

Screenshot 2023-09-04 at 9 38 31 PM Screenshot 2023-09-04 at 9 45 11 PM

@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 5, 2023

Alternative number 2 looks like what we're after. Can you please add a little spacing between the elements?

@roberto-morado
Copy link
Contributor

Sure thing.

@roberto-morado
Copy link
Contributor

?

I prefer the first one.

Screenshot 2023-09-04 at 10 10 30 PM Screenshot 2023-09-04 at 10 13 44 PM Screenshot 2023-09-04 at 10 11 44 PM

CC @iuioiua

@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 5, 2023

2nd one feels best to me. Let's explore more in a PR 🙂

@roberto-morado roberto-morado mentioned this issue Sep 5, 2023
Closed
@iuioiua iuioiua mentioned this issue Sep 10, 2023
Merged
@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 10, 2023 •
edited
Loading

Completed by #553

@iuioiua iuioiua closed this as completed Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberto-morado roberto-morado

Labels
v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve user page header roberto-morado/saaskit
3 participants
@hashrock @iuioiua @roberto-morado