Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user page header #500

Closed
wants to merge 0 commits into from
Closed

Conversation

roberto-morado
Copy link
Contributor

@roberto-morado roberto-morado commented Sep 5, 2023

fixes #468

CC @iuioiua

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this whole component could be greatly simplified using w-full, text-center and space-y-2 classes and a couple of <p> elements. Flex is likely not needed. WDYT?

@roberto-morado
Copy link
Contributor Author

What do you think?

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions:

  1. Make username text larger, maybe text-xl and remove <strong />
  2. Maybe put username and GitHub logo on the same line

I'm not certain about these. WDYT?

@@ -12,27 +12,25 @@ function Profile(
props: { login: string; isSubscribed: boolean },
) {
return (
<div class="flex flex-wrap py-8">
<GitHubAvatarImg login={props.login} size={48} />
<div class="w-full text-center space-y-2 py-8">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can still be a little simpler:

    <div class="w-full text-center space-y-2 py-8 px-4">
      <GitHubAvatarImg login={props.login} size={72} />
      <p>
        <strong>{props.login}</strong>
        {props.isSubscribed && (
          <span title="Deno Hunt premium user">{" "}🦕</span>
        )}
      </p>
      <p class="inline-block">
        <a
          href={`https://github.com/${props.login}`}
          aria-label={`${props.login}'s GitHub profile`}
          class={LINK_STYLES}
          target="_blank"
        >
          <IconBrandGithub class="text-sm w-6" />
        </a>
      </p>
    </div>

@roberto-morado
Copy link
Contributor Author

Let me create a few alternatives from which you can choose and we work from there 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

todo: improve user page header
2 participants