Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: oauth integration #14

Closed
wants to merge 2 commits into from
Closed

feat: oauth integration #14

wants to merge 2 commits into from

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Mar 22, 2023 •
edited
Loading

Implements #13.

Todo:

  • Add a sexy sign-up/sign-in button
  • Change to GitHub provider
  • Figure out how things interplay with Stripe
  • Add integration instructions

@iuioiua
Copy link
Contributor Author

iuioiua commented Mar 22, 2023 •
edited
Loading

Preview deployment is still not working even though it's a non-forked branch, @kt3k. If I understand correctly, this should work, right?

@kt3k
Copy link
Member

kt3k commented Mar 24, 2023

@iuioiua This still looks from your fork (prefixed with your fork name)

Screen Shot 2023-03-24 at 11 54 33

BTW currently saaskit project in Deploy doesn't seem setting any env vars. Do you know who manages those?

@iuioiua
Copy link
Contributor Author

iuioiua commented Mar 24, 2023

Doh! I thought it wasn't a fork 😓

BTW currently saaskit project in Deploy doesn't seem setting any env vars. Do you know who manages those?

It might be Andy. But he hasn't told me of doing so. I'll ask him once he's back.

@iuioiua
Copy link
Contributor Author

iuioiua commented Mar 28, 2023

#16 is a prerequisite for this PR.

@iuioiua
Copy link
Contributor Author

iuioiua commented Apr 3, 2023

Closing in favour of #35.

@iuioiua iuioiua closed this Apr 3, 2023
@iuioiua iuioiua deleted the feat-oauth branch April 3, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k