feat: add upvote function #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
suggested changes
May 4, 2023
There was a problem hiding this comment.
Wow, I like this. I've been wondering how we'd do this, but this provides a clearer picture and is a great foundation to build upon. I feel like this PR might take a bit of back-and-forth before it's ready, so we'll have to exercise some patience 😅
Either way, the common theme in my suggestions is that we can break up some of the logic of this functionality into smaller, simpler pieces.
This comment was marked as off-topic.
This comment was marked as off-topic.
iuioiua
suggested changes
May 8, 2023
|
The CI error appears to be unrelated to this change. Also, can you please change the name of |
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
iuioiua
suggested changes
May 8, 2023
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
|
@huai-jie, I've made a few improvements. PTAL and test. WDYT? |
|
LGTM! |
|
Thank you for all your work, @huai-jie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is really messy ATM
&
I encountered some issues while attempting to do this
Issues:
Any suggestions on how to improve this are really welcome and appreciated.