-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DENO_DEPLOYMENT_ID env variable #155
Conversation
am i understanding the directions correctly RE: docker deployment that for each deployment, you have to run
and then copy and paste that into maybe we suggest using GitHub Actions, in which it will grab the what do you think? |
Co-authored-by: Andy Jiang <andyjiang@gmail.com>
As we talked about on Discord, this is something that we would implement in the future. |
README.md
Outdated
|
||
```sh | ||
# get the SHA1 commit hash of the current branch | ||
git rev-parse HEAD | ||
``` | ||
|
||
Make sure this command is run and value upgraded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can prob remove this part given the re-organization of the information in the paragraph prior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lambtron I agree that the last line (273) needs to be removed, but the git rev-parse HEAD
command should remain as the previous paragraph points to it. Don't you agree?
LGTM after those changes! |
Co-authored-by: Andy Jiang <andyjiang@gmail.com>
Could you please fix the CI errors? |
Is this PR ready to merge? |
Yes |
Done in e180b16 |
Added
DENO_DEPLOYMENT_ID
environmental variable needed for Docker deployment of a DenoFresh app for caching to work properly (see https://fresh.deno.dev/docs/concepts/deployment#docker).