fix: move comment box to top #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, agreed. I think this needs to be done in conjunction with ordering comments from newest (top) to oldest (bottom). Are you able to do that too? |
|
I was going to suggest keeping the order as most upvoted, but I realize comments don't have upvotes (yet?). Is that planning on being added at some point? For this PR I can change the order of comments. |
|
Yeah, comments don't have upvotes. TBH, I'm not sure we'll add it, but that could change. |
|
Fair enough, I'll change the ordering right now to unblock the PR. |
lambtron
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the comment box is at the bottom of the page, which isn't very intuitive. This PR just moves it to the top.