-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: homepage pagination and local db seeding #221
Conversation
…nable display of raw item userId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice approach! Please be sure to run deno task ok
before pushing.
Mostly LGTM! However, I'm now getting the following error after running
I suppose these are what your previous modifications to |
@iuioiua – Yep. To minimize the diffs, I elected to make |
The user deletion flow is not yet defined or implemented. Even if it were, it'd likely delete all objects relating to the user, including posts. |
@iuioiua – for context on my end, I saw a function and a corresponding test for user deletion -> https://github.com/denoland/saaskit/blob/main/utils/db_test.ts#L46 |
Ah, yes. |
@iuioiua – Could you clarify what changes you need for this PR? For demo or local testing purposes, I feel like emulating real users via the |
The changes to |
Also, could you add a short explainer in the README (Getting Started Locally) and seed submissions script about what it does? |
…in script - also add tool to print kv
612776f
to
7d58382
Compare
@iuioiua – PTAL when you have the chance
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work, @zzeleznick 💪🏾
Description
This PR intends to support #211 by adding simple pagination with a
page
URL parameters and a helper script to seed the db with some dummy data.Adds
tools/seed_submissions.ts
script to pull in dummy data from HN for testingpage
option to specify the cursor (noting that there isn't yet a feed design that takes into account the date and score of the submissions)Example
Notes